Unit, integration and GCE e2e test build/test passed for commit d6945c231b115f2b7f3c42f712278efc50328d95.

• Build Log
• Test Artifacts
• Internal Jenkins Results

Labelling this PR as size/XL

Thanks - those tests were causing a lot of pain!

@thockin I'd rather see poller modified to take a immediateCheck bool or something to that effect. PTAL at https://github.com/kubernetes/kubernetes/pull/14981/files. For example:

func poller(interval, timeout time.Duration, immediateCheck bool) WaitFunc {
    return WaitFunc(func() <-chan struct{} {
        ch := make(chan struct{})

        go func() {
            if immediateCheck {
                // send to the channel once immediately, rather than waiting for the first
                // interval to elapse
                ch <- struct{}{}
            }

And then you can implement PollImmediate by calling WaitFor(poller(interval, timeout, true), condition) whereas Poll would be WaitFor(poller(interval, timeout, false), condition).

Ultimately, I'd like us to end up with just 1 function, Poll, that always checks immediately. If a caller would prefer to wait, just add a time.Sleep before calling Poll. WDYT?

cc @smarterclayton

@ncdc the problem with putting it in the poller() func is that tests (which I added, ahem) inject their own need to replicate that logic. I think its cleaner to make that external to the test-provided WaitFunc. Agree with the end goal of one function that does the right thing.

I'd also like to eventually get rid of the "one last time" call on channel close - it's just a weird semantic, but apparently at least some code in the system depends on it (tests break).

I moved the wait change to #14996 - will rebase this when that is in.

Unit, integration and GCE e2e test build/test passed for commit dba564f7a0ee1b987f0bbfd73732bc20aec76314.

• Build Log
• Test Artifacts
• Internal Jenkins Results

This LGTM wrt service changes but I'm still in Central European time, haven't had coffee, and I'm reviewing this on a phone.

Rebased now that PollImmediate is in

Unit, integration and GCE e2e test build/test passed for commit 2f7552050bb37df319699259782005288734e84a.

• Build Log
• Test Artifacts
• Internal Jenkins Results

@thockin needs another rebase, by the looks of things.

Unit, integration and GCE e2e test build/test passed for commit ada7489.

• Build Log
• Test Artifacts
• Internal Jenkins Results